Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust ets tables parameters #3317

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Adjust ets tables parameters #3317

merged 1 commit into from
Oct 4, 2021

Conversation

NelsonVides
Copy link
Collaborator

These IQ tables are accessed concurrently by all c2s process,
potentially it tight loops, but they're rarely modified and then only
by their process owner, so it really makes sense to have them as
read_concurrency and protected.

These IQ tables are accessed concurrently by all c2s process,
potentially it tight loops, but they're rarely modified and then only
by their process owner, so it really makes sense to have them as
read_concurrency and protected.
@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 4, 2021

small_tests_24 / small_tests / 005f1a8
Reports root / small


internal_mnesia_24 / internal_mnesia / 005f1a8
Reports root/ big
OK: 1589 / Failed: 0 / User-skipped: 297 / Auto-skipped: 0


small_tests_23 / small_tests / 005f1a8
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 005f1a8
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0


dynamic_domains_24 / pgsql_mnesia / 005f1a8
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


dynamic_domains_23 / pgsql_mnesia / 005f1a8
Reports root/ big
OK: 2702 / Failed: 0 / User-skipped: 184 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / 005f1a8
Reports root/ big
OK: 1486 / Failed: 0 / User-skipped: 400 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 005f1a8
Reports root/ big
OK: 1862 / Failed: 0 / User-skipped: 323 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / 005f1a8
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 005f1a8
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / 005f1a8
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 211 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / 005f1a8
Reports root/ big
OK: 3079 / Failed: 1 / User-skipped: 228 / Auto-skipped: 0

rest_client_SUITE:muc:messages_can_be_paginated_in_room
{error,
  {{assertion_failed,assert,is_chat_message,
     [<<"eeb6921d">>],
     {xmlel,<<"message">>,
       [{<<"to">>,<<"[email protected]">>},
        {<<"type">>,<<"chat">>}],
       [{xmlel,<<"body">>,[],[{xmlcdata,<<"3724aca7">>}]}]},
     "<message to='[email protected]' type='chat'><body>3724aca7</body></message>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
       {line,84}]},
    {rest_client_SUITE,assert_room_messages,2,
      [{file,"/home/circleci/app/big_tests/tests/rest_client_SUITE.erl"},
       {line,772}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log


riak_mnesia_24 / riak_mnesia / 005f1a8
Reports root/ big
OK: 1709 / Failed: 0 / User-skipped: 326 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

Merging #3317 (005f1a8) into master (09204c1) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3317      +/-   ##
==========================================
+ Coverage   80.70%   80.72%   +0.01%     
==========================================
  Files         397      397              
  Lines       32439    32439              
==========================================
+ Hits        26180    26185       +5     
+ Misses       6259     6254       -5     
Impacted Files Coverage Δ
src/ejabberd_local.erl 77.34% <100.00%> (ø)
src/ejabberd_sm.erl 84.59% <100.00%> (ø)
src/mongoose_tcp_listener.erl 76.59% <0.00%> (-4.26%) ⬇️
src/domain/mongoose_domain_sql.erl 82.85% <0.00%> (-2.86%) ⬇️
...c/global_distrib/mod_global_distrib_server_mgr.erl 74.57% <0.00%> (-2.26%) ⬇️
src/global_distrib/mod_global_distrib_receiver.erl 80.00% <0.00%> (-1.12%) ⬇️
src/mam/mod_mam.erl 88.33% <0.00%> (-0.84%) ⬇️
src/metrics/mongoose_metrics.erl 95.45% <0.00%> (-0.65%) ⬇️
src/ejabberd_c2s.erl 89.07% <0.00%> (-0.45%) ⬇️
src/mod_muc_room.erl 77.18% <0.00%> (+0.05%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09204c1...005f1a8. Read the comment docs.

@NelsonVides NelsonVides requested review from chrzaszcz and DenysGonchar and removed request for chrzaszcz October 4, 2021 12:04
Copy link
Collaborator

@DenysGonchar DenysGonchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vkatsuba vkatsuba merged commit c193afe into master Oct 4, 2021
@vkatsuba vkatsuba deleted the iq_tables_read_concurrency branch October 4, 2021 13:03
@Premwoik Premwoik added this to the 5.0.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants