-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust ets tables parameters #3317
Conversation
These IQ tables are accessed concurrently by all c2s process, potentially it tight loops, but they're rarely modified and then only by their process owner, so it really makes sense to have them as read_concurrency and protected.
small_tests_24 / small_tests / 005f1a8 internal_mnesia_24 / internal_mnesia / 005f1a8 small_tests_23 / small_tests / 005f1a8 ldap_mnesia_24 / ldap_mnesia / 005f1a8 dynamic_domains_24 / pgsql_mnesia / 005f1a8 dynamic_domains_23 / pgsql_mnesia / 005f1a8 ldap_mnesia_23 / ldap_mnesia / 005f1a8 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 005f1a8 pgsql_mnesia_23 / pgsql_mnesia / 005f1a8 pgsql_mnesia_24 / pgsql_mnesia / 005f1a8 mssql_mnesia_24 / odbc_mssql_mnesia / 005f1a8 mysql_redis_24 / mysql_redis / 005f1a8 rest_client_SUITE:muc:messages_can_be_paginated_in_room{error,
{{assertion_failed,assert,is_chat_message,
[<<"eeb6921d">>],
{xmlel,<<"message">>,
[{<<"to">>,<<"[email protected]">>},
{<<"type">>,<<"chat">>}],
[{xmlel,<<"body">>,[],[{xmlcdata,<<"3724aca7">>}]}]},
"<message to='[email protected]' type='chat'><body>3724aca7</body></message>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{rest_client_SUITE,assert_room_messages,2,
[{file,"/home/circleci/app/big_tests/tests/rest_client_SUITE.erl"},
{line,772}]},
{escalus_story,story,4,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} riak_mnesia_24 / riak_mnesia / 005f1a8 |
Codecov Report
@@ Coverage Diff @@
## master #3317 +/- ##
==========================================
+ Coverage 80.70% 80.72% +0.01%
==========================================
Files 397 397
Lines 32439 32439
==========================================
+ Hits 26180 26185 +5
+ Misses 6259 6254 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
These IQ tables are accessed concurrently by all c2s process,
potentially it tight loops, but they're rarely modified and then only
by their process owner, so it really makes sense to have them as
read_concurrency and protected.